Documentation for RR and Strict Queues #2223
Conversation
…ze_pifo_oracle
…ze_pifo_oracle merge to pull
|
Whoops there's something wrong with the commit history. I think it's because you made this branch while on an old commit of |
There was a problem hiding this comment.
As described in #2226, I am requesting a broader change to this text and I'll review this PR after those changes are in! For now maybe mark this one as a draft?
…/calyx into queues-doc-rr-and-strict
|
Because of the same mistake I had made earlier with branching off a deleted branch, please disregard this PR and instead review #2237. |
This PR makes progress towards #2226 by updating variable names and comments to account for the fact that round robin PIFOs can make n-way trees. Additionally, it implements a PIFO tree and a more complicated tree (`complicated_tree.py`) using round robin and strict queues. This accounts for the first three checkboxes of #2226. The docs have been updated to reflect the new PIFO style in #2223. To run the relevant tests, ``` runt -i "queues" ``` (For sdn.py, I removed the stats component stuff because I thought it was mentioned that this wasn't important and so the new style PIFOs are not equipped to do stats. If it needs to be there, let me know.) --------- Co-authored-by: Anshuman Mohan <[email protected]>
This PR makes progress towards #2191 by adding documentation about round robin and strict queues. Additionally, it completes the last checkbox of #2226 by updating the documentation to use the new style of PIFOs. Recently, it also updates the documentation to reflect the removal of peek (#2241). Because of a git mistake carried forward, this PR supersedes #2223. --------- Co-authored-by: Anshuman Mohan <[email protected]>
This PR makes progress towards #2191 by adding documentation about round robin and strict queues. Additionally, it completes the last checkbox of #2226 by updating the documentation to use the new style of PIFOs.