-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report error on unsupported era #1219
Conversation
a6790bd
to
6f72074
Compare
6f72074
to
158f342
Compare
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionThis is using ada-only outputs for better comparability.
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
End-To-End Benchmark ResultsThis page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes. Generated at 2023-12-22 14:23:51.931550908 UTC Baseline Scenario
Baseline Scenario
|
e3ffa36
to
2354b1b
Compare
2354b1b
to
a89284b
Compare
a89284b
to
29395ba
Compare
As it seems to be confusing otherwise.
This updates the node config file by addin a field that is going to trigger the fork at certain epoch.
Also change the approach of how to handle the create process, by using alternatives
This is not yet migrating the ConfigurationExceptions which are relying on a call to 'explain' on the hydra-node 'Run' case.
By implementing displayException for QueryException. publishHydraScriptsAs does not supports Conway; for that reason we delayed the fork so that the hydra scripts are published under Babbage.
fd80a6e
to
c00ca7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I added some comments, potential improvements and perhaps one unneeded function parameter.
773f52d
to
03d136b
Compare
03d136b
to
d383b8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good.. but please do revert cabal.project
before merging.
If we want to turn off -Werror, we should use cabal configure as described in the contributing guidelines.
So they explicitly describe the era missmatch. Also included some formatting changes.
By providing informationa about the era mismatch that triggered it.
Remove outdated reference to shelley genesis file from comment.
f59a879
to
4341484
Compare
Added queryEpochNo to cardano-node client to support this operation.
2b3c271
to
c1ffcb5
Compare
9633771
to
a22e308
Compare
Required for Conway Support #1177
⛄ Add e2e tests to check the hydra-node survives a fork (like Conway) and report on unsupported era:
publishHydraScriptsAs
does not supports the new era Conway, we had to delay the fork so that the hydra scripts are published under the current supported Babbage.⛄ throw
EraNotSupportedException
in the direct chain component when we detect blocks from a different era.⛄ Use
displayException
in hydra-node to explain exceptions rised during a change of era, like:⛄ Implement helper function (
forkIntoConwayInEpoch
) to simulate a change of era, by using a cardano-config file that will trigger a fork in the cardano-node when it reaches a certain epoch.⛄ Enhance cardano-node setup in devnet.
⛄ Add missing
genDelegs
attribute to genesis-conway config file, as is needed for cardano-node to run and produce Conway blocks in devnet.⛄ Reduce
epochLength
in genesis-shelley config file, to trigger a fork in the cardano-node faster.