Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report error on unsupported era #1219

Merged
merged 38 commits into from
Dec 22, 2023
Merged

Report error on unsupported era #1219

merged 38 commits into from
Dec 22, 2023

Commits on Dec 20, 2023

  1. Add test stub for surviving a conway fork

    @locallycompact @ffakenz
    locallycompact authored and ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c83adaf View commit details
    Browse the repository at this point in the history

  2. Draft era mismatch e2e test and configurable Devnet setup

    @ch1bo @ffakenz
    ch1bo authored and ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    bc7c41a View commit details
    Browse the repository at this point in the history

  3. Resolve TODO for setting up cardano node in devnet

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    852f355 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary config from default

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    62e2469 View commit details
    Browse the repository at this point in the history

  5. Change default cardano node config file name to match ours 

    As it seems to be confusing otherwise.
    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    e0c3d12 View commit details
    Browse the repository at this point in the history

  6. Implement forkIntoConwayInEpoch function 

    This updates the node config file by addin a field
that is going to trigger the fork at certain epoch.
    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    2d98b3f View commit details
    Browse the repository at this point in the history

  7. fix forkIntoConwayInEpoch by passing the stateDirectory to find the c… 

    …onfig file
    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    8f64c76 View commit details
    Browse the repository at this point in the history

  8. Add genDelegs to genesis-conway as it is needed for cardano-node to run

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a7ef7ec View commit details
    Browse the repository at this point in the history

  9. Make stderr configurable in withHydraNode

    @locallycompact @ffakenz
    locallycompact authored and ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    bfb796d View commit details
    Browse the repository at this point in the history

  10. Fetch slotLength and epochLength from args

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a7977c0 View commit details
    Browse the repository at this point in the history

  11. Introduce ChainClientException and try to catch it as part of e2e 

    Also change the approach of how to handle the create process, by using alternatives
    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    07bb345 View commit details
    Browse the repository at this point in the history

  12. Fix end-to-end test on non-supported cardano era

    @ch1bo @ffakenz
    ch1bo authored and ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    3dacdf1 View commit details
    Browse the repository at this point in the history

  13. Use displayException in hydra-node to explain EraNotSupportedException 

    This is not yet migrating the ConfigurationExceptions which are relying
on a call to 'explain' on the hydra-node 'Run' case.
    @ch1bo @ffakenz
    ch1bo authored and ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    74f4dc1 View commit details
    Browse the repository at this point in the history

  14. Draft another e2e test about node failing on incorrect era

    @ch1bo @ffakenz
    ch1bo authored and ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1e37e59 View commit details
    Browse the repository at this point in the history

  15. Fix e2e spec to report on startup 

    By implementing displayException for QueryException.

publishHydraScriptsAs does not supports Conway; for that reason
we delayed the fork so that the hydra scripts are published under Babbage.
    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    cd63e5a View commit details
    Browse the repository at this point in the history

  16. Minor formatting changes

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    fcc24c7 View commit details
    Browse the repository at this point in the history

  17. Migrate configuration exceptions to use displayException to explain

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    ad88952 View commit details
    Browse the repository at this point in the history

  18. Update CHANGELOG

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    5a019ff View commit details
    Browse the repository at this point in the history

  19. Update explain messages for not supported era exceptions

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c34532f View commit details
    Browse the repository at this point in the history

  20. Improve getField helper function by using lenses

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1443e45 View commit details
    Browse the repository at this point in the history

  21. Reduce epochLengh even further to speedup tests depending on it

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c00ca7e View commit details
    Browse the repository at this point in the history

  22. Apply review changes

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d383b8c View commit details
    Browse the repository at this point in the history

  23. Remove stderr to be configurable in withHydraNode, as not needed

    @ffakenz
    ffakenz committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    0005a09 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Revert cabal.project changes in code 

    If we want to turn off -Werror, we should use cabal configure as
described in the contributing guidelines.
    @ffakenz
    ffakenz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    dc38469 View commit details
    Browse the repository at this point in the history

  2. Minor fix to error output assertions

    @ffakenz
    ffakenz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    63a8e79 View commit details
    Browse the repository at this point in the history

  3. Remove addField helper, use aeson-lenses instead

    @ffakenz
    ffakenz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    eb25cb0 View commit details
    Browse the repository at this point in the history

  4. Improve era missmatch error messages 

    So they explicitly describe the era missmatch.

Also included some formatting changes.
    @ffakenz
    ffakenz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    91d4c19 View commit details
    Browse the repository at this point in the history

  5. Enhance error msg for EraNotSupportedException 

    By providing informationa about the era mismatch that triggered it.
    @ffakenz
    ffakenz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    92247a1 View commit details
    Browse the repository at this point in the history

  6. Update fourmolu fixities to match treefmt rules

    @ffakenz
    ffakenz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    a8dceda View commit details
    Browse the repository at this point in the history

  7. Minor haddock fix 

    Remove outdated reference to shelley genesis file from comment.
    @ffakenz
    ffakenz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d45ff93 View commit details
    Browse the repository at this point in the history

  8. Remove getField helper, use aeson-lenses instead

    @ffakenz
    ffakenz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    4341484 View commit details
    Browse the repository at this point in the history

  9. Minor formatting changes

    @ffakenz
    ffakenz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    ed41f2d View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Improved delayEpoch so it waits until it reaches the target epoch 

    Added queryEpochNo to cardano-node client to support this operation.
    @ffakenz
    ffakenz committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    c1ffcb5 View commit details
    Browse the repository at this point in the history

  2. Revert "Update fourmolu fixities to match treefmt rules" 

    This reverts commit a8dceda.
    @ffakenz
    ffakenz committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    3b458e3 View commit details
    Browse the repository at this point in the history

  3. Minor formatting changes

    @ffakenz
    ffakenz committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    7b1b1c6 View commit details
    Browse the repository at this point in the history

  4. Fix formatting for <&> in presence of ?~

    @ch1bo
    ch1bo committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    a22e308 View commit details
    Browse the repository at this point in the history

  5. Remove commented code

    @ffakenz
    ffakenz committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    46d0f1b View commit details
    Browse the repository at this point in the history

  6. Improve error messages by using printf

    @ffakenz
    ffakenz committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    a67ec3e View commit details
    Browse the repository at this point in the history