-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup incremental decommit - Part 1 #1491
Cleanup incremental decommit - Part 1 #1491
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionThis is using ada-only outputs for better comparability.
Cost of CollectCom Transaction
Cost of Decrement Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
End-To-End Benchmark ResultsThis page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes. Generated at 2024-07-11 08:33:13.158636611 UTC Baseline Scenario
Three local nodes
|
bc3aebd
to
7d0f1e9
Compare
e1038aa
to
ec8f37d
Compare
Enabled mutation tests and updated scripts
363bd2a
to
8053d19
Compare
This further aligns implementation with the spec and makes for a clearer case separation.
The healthy case of close "outdated" mutations was also not correctly setting up the versions.
Seems like the previous practice of incrementing version in HeadLogic was prone to race conditions.
e214114
to
ea14c48
Compare
This allows us to align the HeadLogic part about clearing pending decommits more faithfully. Required to add a new method `outputsOfUTxO` to `IsTx` which feels to become a bit "too big" for a type class.
ea14c48
to
4d0bf40
Compare
adcf1a9
to
2ea5ae2
Compare
2ea5ae2
to
48a2e62
Compare
38823d1
to
704ff0f
Compare
63bce1b
to
7f0c9b0
Compare
47def10
to
e79dfed
Compare
A first round of things which stood out to me when reviewing #1344:
Removed unnecessary changes of cardano-configurations, incrementTx figure from spec, a renaming in the spec and moved sequence diagram in the docs
Renamed the tx benchmark to
decrement
Added missing version checks validators
Major refactor of close/contest with the new redeemer classes (to align with the spec)
Removed redundant snapshot number checks
Made
deltaUTxOHash
aMaybe Hash
Some further refactor of on-chain types into sub-types (to be more type-safe.. but could have been another PR).
ReqDec handling similar to ReqTx handling (DecommitInvalid similar to TxInvalid behavior).
Align signable representation with spec (order or arguments in tuple)
This does target #1344 and should resolve many conversations (my notes I left).