Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup incremental decommit - Part 1 #1491

Merged
merged 29 commits into from
Jul 15, 2024
Merged

Cleanup incremental decommit - Part 1 #1491

merged 29 commits into from
Jul 15, 2024

Commits on Jul 9, 2024

  1. Not update cardano-configurations submodule

    @ch1bo
    ch1bo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    00fbc89 View commit details
    Browse the repository at this point in the history

  2. Drop unused incrementTx figure from spec

    @ch1bo
    ch1bo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a9f1b71 View commit details
    Browse the repository at this point in the history

  3. Revert fanout m' renaming

    @ch1bo
    ch1bo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    aafde9f View commit details
    Browse the repository at this point in the history

  4. Rename tx cost benchmark decommit -> decrement

    @ch1bo
    ch1bo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5c28382 View commit details
    Browse the repository at this point in the history

  5. Don't use splitUTxO and use version 0 in tx-cost benchmark

    @ch1bo
    ch1bo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7d0f1e9 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Move sequence diagram into dedicated docs page

    @ch1bo
    ch1bo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ec8f37d View commit details
    Browse the repository at this point in the history

  2. Must not change version in close/contest 

    Enabled mutation tests and updated scripts
    @ch1bo
    ch1bo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    56cb757 View commit details
    Browse the repository at this point in the history

  3. Limit size of generated contesters to reasonable values

    @ch1bo
    ch1bo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4429b42 View commit details
    Browse the repository at this point in the history

  4. Broaden version mutation for collect

    @ch1bo
    ch1bo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4a7d6bd View commit details
    Browse the repository at this point in the history

  5. Broaden version mutation for decrement

    @ch1bo
    ch1bo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    06919e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Introduce CloseRedeemer and ContestRedeemer 

    This further aligns implementation with the spec and makes for a clearer
case separation.
    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3df2659 View commit details
    Browse the repository at this point in the history

  2. Use redeemers in tx construction

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    eb8da4b View commit details
    Browse the repository at this point in the history

  3. Use redeemers in mutation tests

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f8647ca View commit details
    Browse the repository at this point in the history

  4. Remove a now invalid mutation test

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d6ff1db View commit details
    Browse the repository at this point in the history

  5. Fix close transaction to use last open state version in output 

    The healthy case of close "outdated" mutations was also not correctly
setting up the versions.
    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    effdad4 View commit details
    Browse the repository at this point in the history

  6. Add newVersion to OnDecrementTx and fix off-chain protocol 

    Seems like the previous practice of incrementing version in HeadLogic
was prone to race conditions.
    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    654a4da View commit details
    Browse the repository at this point in the history

  7. Observe distributed outputs from decrementTx 

    This allows us to align the HeadLogic part about clearing pending
decommits more faithfully.

Required to add a new method `outputsOfUTxO` to `IsTx` which feels to
become a bit "too big" for a type class.
    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9a67bda View commit details
    Browse the repository at this point in the history

  8. Remove snapshot number from open state and introduce sub-types

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    760220b View commit details
    Browse the repository at this point in the history

  9. Do not expect decrements with snapshot number 0 to fail

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4d0bf40 View commit details
    Browse the repository at this point in the history

  10. Use sub-types for decrement/close in head validator

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ba470df View commit details
    Browse the repository at this point in the history

  11. Remove redundant strictness annotations in Head script

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9681e48 View commit details
    Browse the repository at this point in the history

  12. Rename and re-number head errors

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    48a2e62 View commit details
    Browse the repository at this point in the history

  13. Emit snapshot with cleared decommitTx onDecrementTx

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1f166b7 View commit details
    Browse the repository at this point in the history

  14. Sub-type closedDatum and make deltaHash a Maybe

    @ch1bo
    ch1bo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d6ba7be View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Re-order Snapshot fields and align signable representation with spec

    @ch1bo
    ch1bo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    3ad2115 View commit details
    Browse the repository at this point in the history

  2. Add TODO about preventing empty decommits

    @ch1bo
    ch1bo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    705c257 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Change Decommit server outputs to be more in-line with TxValid/TxInvalid 

    This resolves a TODO (REVIEW) comment
    @ch1bo
    ch1bo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    fd8c039 View commit details
    Browse the repository at this point in the history

  2. Regenerate golden files and make XXX comments mention Spec instead

    @ch1bo
    ch1bo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    38de24c View commit details
    Browse the repository at this point in the history

  3. Fix contest off-chain

    @ch1bo
    ch1bo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e79dfed View commit details
    Browse the repository at this point in the history