Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github groups #2482

Closed
wants to merge 4 commits into from
Closed

feat: github groups #2482

wants to merge 4 commits into from

Conversation

GauBen
Copy link

@GauBen GauBen commented Nov 26, 2024

@GauBen
Copy link
Author

GauBen commented Nov 26, 2024

It's me again @casey, can you please allow workflows to run on this PR?

@GauBen
Copy link
Author

GauBen commented Nov 26, 2024

Thank you! What do you think of this https://github.com/casey/just/actions/runs/12038853590/job/33566940915#step:4:209 ?

@casey
Copy link
Owner

casey commented Nov 26, 2024

Hmm, interesting. I think that a group per command is probably too much. If a recipe has many small commands, then putting each in a group is probably going to be too noisy.

Can you change it to be per-recipe so we can see what it looks like?

A risk with a feature like this is that we won't be able to do it well automatically, and we should leave it to the justfile author, since they are in a better position to know how to group output.

@GauBen GauBen force-pushed the feat/github-groups branch from 5c88ba2 to 2839685 Compare December 1, 2024 10:50
@GauBen
Copy link
Author

GauBen commented Dec 1, 2024

I updated this MR with per-recipe grouping, can you please run the workflow?

@casey
Copy link
Owner

casey commented Dec 10, 2024

Just re-ran it. The output still isn't great, for example, the nested group isn't within the outer group, and the commands in the outer group after the nested group don't appear in the right group.

Also, recipe names are sometimes not the most explicit, and so aren't great for log messages.

I'm thinking that this is something which is probably best handled by the justfile author themselves, and we won't be able to do it very well without understanding how they're using just.

@casey casey closed this Dec 10, 2024
@GauBen
Copy link
Author

GauBen commented Dec 11, 2024

Yep, that's not a good fit for a native just feature, but glad we tried!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants