NUT-04: Add optional description for PostMintQuoteBolt11Request #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minibits-cash
changed the title
|
As mentioned on the dev call since this may not be supported by all backends it would be best to add signalling for it on the MintInfo endpoint. A boolean field could be added to the Mint Settings something like |
This was referenced Sep 8, 2024
callebtc
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends PostMintQuoteBolt11Request by optional description field. Description is then ought to be passed to the lightning backend by the mint and included in the returned bolt11 invoice.
Considered two options for param name: memo and description, leaning to the latter as it is more generic and decoded bolt11 invoice uses the same term.