Followup to #145 #155
Merged
Followup to #145 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khieta
commented
Nov 16, 2023
| 1 => Ok(PrincipalOrResourceConstraint::IsType(ety)), | ||
| 1 => Ok(PrincipalOrResourceConstraint::IsTypeIn(ety, uid)) | ||
| ) | ||
| } | ||
| } | ||
| fn arbitrary_principal_constraint_size_hint(depth: usize) -> (usize, Option<usize>) { |
There was a problem hiding this comment.
I'm not sure whether/how the *_size_hint functions need to be updated. Suggestions welcome.
There was a problem hiding this comment.
@cdisselkoen may have written the original
There was a problem hiding this comment.
They are mostly performance optimizations; see docs on Arbitrary::size_hint. If/when we migrate to Bolero, they will go away.
There was a problem hiding this comment.
So it's fine to leave these functions as-is?
john-h-kastner-aws
approved these changes
Nov 16, 2023
andrewmwells-amazon
approved these changes
Nov 16, 2023
cdisselkoen
approved these changes
Nov 16, 2023
Comment on lines
+1042
to
+1044
| let uid = self | ||
| .exprgenerator(Some(hierarchy)) | ||
| .arbitrary_principal_uid(u)?; |
There was a problem hiding this comment.
generates the uid even in the IsType case where it isn't used. Probably ok though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Followup to #145, which updated generators with support for the
isoperator. This PR adds support for generatingisin scope constraints toschema.rs(which is used for most DRT targets). It mirrors the corresponding change made previously inpolicy.rs(which is used for therbactarget).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.