-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main PE soundness theorems #402
Draft
cdisselkoen
wants to merge
10
commits into
main
Choose a base branch
from
cdisselkoen/pe-soundness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
We need typed unknowns :) |
Signed-off-by: Craig Disselkoen <[email protected]>
3 tasks
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the main soundness theorems for partial authorization (in
Thm/Partial/Authorization.lean
) and partial evaluation (inThm/Partial/Evaluation.lean
). Draft for now because although it contains over 5K lines of proof (!), it also still contains approximately 52sorry
s (!)This PR also fixes a few soundness problems which otherwise prevent the theorems from holding (!):
Partial.Response
no longer carry a copy of the specific error, just the ID of the policy that errored, so that structural equality ofPartial.Response
has the intended semantics (matching how the spec authorizer is specified; see Lean: Specify authz response includes ids of erroring policies #206).true && residual
cannot returnresidual
in all cases. Consider the case whereresidual
is a single unknown, and that we substitute it with37
. We need the substitute-and-reevaluate operation to return type-error, not37
. This PR has partial evaluation just returntrue && residual
in all these cases. More precision is possible in the future, but not required for soundness.false || residual
.Partial.evaluate
andPartial.evaluateValue
.principal
,context
, etc) or aGetAttr
getting an entity attribute, instead of returning the partial value directly, it needs toevaluateValue
it, in case the partial value contains a residual that could be (fully) evaluated (e.g., because a substitution operation was recently performed on it).