Add Entity Slicing using Entity Manifests to Cedar #1105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR stacks on top of #1102 |
oflatt
commented
Jul 31, 2024
|
Looks like changing the API for cedar testing broke downstream dependencies build |
oflatt
force-pushed
the
oflatt-entity-slicing
branch
from
9a1ad2c to
d01fc15
Compare
oflatt
force-pushed
the
oflatt-entity-slicing
branch
6 times, most recently
from
2c99077 to
a1243fc
Compare
oflatt
changed the base branch from
main
to
oflatt/entity-manifest-minimal-cedar-repo
oflatt
force-pushed
the
oflatt-entity-slicing
branch
2 times, most recently
from
e02a451 to
cb1188b
Compare
oflatt
force-pushed
the
oflatt/entity-manifest-minimal-cedar-repo
branch
from
2445b74 to
ad8e43b
Compare
oflatt
force-pushed
the
oflatt-entity-slicing
branch
2 times, most recently
from
2592e0b to
1b72442
Compare
oflatt
force-pushed
the
oflatt/entity-manifest-minimal-cedar-repo
branch
from
ad8e43b to
3604eba
Compare
oflatt
force-pushed
the
oflatt-entity-slicing
branch
from
1b72442 to
7d3b2e7
Compare
11 tasks
oflatt
changed the base branch from
oflatt/entity-manifest-minimal-cedar-repo
to
main
Signed-off-by: oflatt <[email protected]> fix up after rebase Signed-off-by: oflatt <[email protected]> more bad rebase cleanup Signed-off-by: oflatt <[email protected]> more small cleanup Signed-off-by: oflatt <[email protected]> some cleanup Signed-off-by: oflatt <[email protected]> separate entity slicing from manifest file Signed-off-by: oflatt <[email protected]> remove simple entity loader for now Signed-off-by: oflatt <[email protected]> exhaustive Signed-off-by: oflatt <[email protected]> fix up testing infra with feature flag Signed-off-by: oflatt <[email protected]> nits Signed-off-by: oflatt <[email protected]> fix up should panic Signed-off-by: oflatt <[email protected]> remove use of panic from testing infra Signed-off-by: oflatt <[email protected]> nits Signed-off-by: oflatt <[email protected]> entity manifest cfg Signed-off-by: oflatt <[email protected]> make errors more reusable Signed-off-by: oflatt <[email protected]> revert cedar testing changes Signed-off-by: oflatt <[email protected]> fmt Signed-off-by: oflatt <[email protected]>
oflatt
force-pushed
the
oflatt-entity-slicing
branch
from
7d3b2e7 to
484a00c
Compare
Signed-off-by: oflatt <[email protected]>
This was referenced Sep 16, 2024
shaobo-he-aws
requested changes
Sep 18, 2024
| @@ -318,6 +318,49 @@ pub struct Entity { | |||
| } | |||
|
|
|||
| impl Entity { | |||
| /// The implementation of [`Eq`] and [`PartialEq`] for | |||
There was a problem hiding this comment.
Can you add the feature flag to core as well?
There was a problem hiding this comment.
Or generally, do you need changes to core at all? It seems you can put everything into the validator.
|
Closed in favor of a single PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR allows users of Cedar to get an entity slice of an existing
Entitiesstore using the entity manifest.Mainly this is useful for testing entity manifests. However, it may also be useful for users to load all entities in to memory, but only send a slice over the network to a server.
Later, I re-implemented most of this code in #1208. You can squash this code with all the PRs on top of it into one giant PR, or just review this and then review the replacement.
PR stack:
#1102 (Merged)
#1105 (This PR)
#1154
#1156
#1171
#1196
#1208
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).cedar-policy(e.g., addition of a new API).cedar-policy.cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)