Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Slicing: Support loading of particular entity ancestors #1171

Conversation

oflatt
Copy link
Contributor

@oflatt oflatt commented Sep 3, 2024

Description of changes

This PR extends entity manifests to describe in particular what Cedar ancestors are required. This can greatly reduce the data required, since entities may have many ancestors. This change is implemented by re-using the existing access trie data structure to describe all the ancestors required.

PR stack:
#1102
#1105
#1154
#1156
#1171 (This PR)
#1196
#1208

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
  • A bug fix or other functionality change requiring a patch to cedar-policy.
  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
  • Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
  • I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

@oflatt oflatt force-pushed the oflatt/entity-manifest-ancestors branch from 7a436db to a5d0aa9 Compare September 3, 2024 23:21
@oflatt oflatt changed the base branch from main to oflatt/entity-manifest-integration-tests September 3, 2024 23:36
@oflatt oflatt marked this pull request as ready for review September 3, 2024 23:36
@oflatt
Copy link
Contributor Author

oflatt commented Sep 10, 2024

Here's a slide that describes what this PR is doing:
image

In the actual implementation, these green "pointers" are actually implemented by storing another trie

@shaobo-he-aws
Copy link
Contributor

Closed in favor of a single PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants