Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization to JSON/protobuf to CLI #1326

Merged
merged 10 commits into from
Nov 22, 2024
Merged

Add serialization to JSON/protobuf to CLI #1326

merged 10 commits into from
Nov 22, 2024

Conversation

andrewmwells-amazon
Copy link
Contributor

@andrewmwells-amazon andrewmwells-amazon commented Nov 19, 2024 •
edited
Loading

Description of changes

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.

@andrewmwells-amazon andrewmwells-amazon marked this pull request as ready for review November 20, 2024 23:11
cdisselkoen
cdisselkoen reviewed Nov 21, 2024
View reviewed changes
cedar-policy-cli/Cargo.toml Outdated Show resolved Hide resolved
cedar-policy-cli/Cargo.toml Outdated Show resolved Hide resolved
cedar-policy-cli/Cargo.toml Outdated Show resolved Hide resolved
cedar-policy-cli/build.rs Show resolved Hide resolved
cedar-policy-cli/protobuf_schema/CLI.proto Outdated Show resolved Hide resolved
cedar-policy-cli/src/lib.rs Outdated Show resolved Hide resolved
cedar-policy-cli/src/lib.rs Outdated Show resolved Hide resolved
cedar-policy-cli/src/lib.rs Show resolved Hide resolved
cedar-policy-cli/src/lib.rs Outdated Show resolved Hide resolved
cedar-policy-cli/src/main.rs Outdated Show resolved Hide resolved
@andrewmwells-amazon
fix CI
966fcf6 
Signed-off-by: Andrew Wells <[email protected]>
@andrewmwells-amazon
fix CI
70be176 
Signed-off-by: Andrew Wells <[email protected]>
@andrewmwells-amazon
Address review comments
7a8fd80 
Signed-off-by: Andrew Wells <[email protected]>
@andrewmwells-amazon
copy .proto files from core and validator into cli for independent ca…
630c3aa 
…rgo build

Signed-off-by: Andrew Wells <[email protected]>
@andrewmwells-amazon
Address review comments
3ce65ee 
Signed-off-by: Andrew Wells <[email protected]>
@andrewmwells-amazon andrewmwells-amazon merged commit 3166f9b into main Nov 22, 2024
19 checks passed
@andrewmwells-amazon andrewmwells-amazon deleted the andrewmwells/protobuf_cli branch November 22, 2024 18:48
@john-h-kastner-aws john-h-kastner-aws mentioned this pull request Nov 26, 2024
Merged
@cdisselkoen cdisselkoen mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-h-kastner-aws john-h-kastner-aws john-h-kastner-aws left review comments

@shaobo-he-aws shaobo-he-aws shaobo-he-aws approved these changes

@cdisselkoen cdisselkoen cdisselkoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewmwells-amazon @cdisselkoen @shaobo-he-aws @john-h-kastner-aws