feat: return sdk response with more fields inc the signer #6036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cmwaters
reviewed
Oct 17, 2025
ninabarbakadze
commented
Oct 21, 2025
Comment on lines
+99
to
+102
| ErrorLog string | ||
| Codespace string | ||
| GasWanted int64 | ||
| GasUsed int64 |
There was a problem hiding this comment.
do we want to add signer in the execution error as well?
Created the v2 wrapper @evan-forbes feel free to take a look at my approach. Once we bump the SDK I'll take another pass thru and open the PR. |
ninabarbakadze
requested review from
evan-forbes,
rach-id and
rootulp
as code owners
rootulp
previously approved these changes
Oct 30, 2025
pkg/user/utils/txclient_utils.go
Outdated
| WithModifiers(genesis.SetBlobParams(enc.Codec, defaultBlobParams)) | ||
| // WithSuppressLogs(false) | ||
|
|
||
| testnodeConfig.Genesis.ConsensusParams.Block.MaxBytes = blocksize |
There was a problem hiding this comment.
[question] is it not possible to override this via a With___ function after testnode.DefaultConfig()?
There was a problem hiding this comment.
Added it myself 692baae
evan-forbes
reviewed
Oct 30, 2025
pkg/user/v2/tx_client.go
Outdated
Comment on lines
18
to
23
| // NewTxClient creates a new v2 TxClient wrapper around the provided TxClient | ||
| func NewTxClient(client *user.TxClient) *TxClient { | ||
| return &TxClient{ | ||
| TxClient: client, | ||
| } | ||
| } |
There was a problem hiding this comment.
could we wrap the new function as well so the creator doesn't have to create v1 then wrap?
so
package v2
func New(args) {
v1.New(args)
etc
Co-authored-by: Rootul P <[email protected]>
|
I think lint was broken on main fixed it e07e24c |
rootulp
approved these changes
Nov 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #5945
Fixes #5992