Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modshare): implement GetRow #4002

Merged
merged 8 commits into from
Jan 9, 2025
Merged

feat(modshare): implement GetRow #4002

merged 8 commits into from
Jan 9, 2025

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Dec 11, 2024 •
edited
Loading

closes #3981

@vgonkivs vgonkivs added kind:feat Attached to feature PRs shwap labels Dec 11, 2024
@vgonkivs vgonkivs self-assigned this Dec 11, 2024
@vgonkivs vgonkivs changed the title feat(shwap): implement GetRow feat(modshare): implement GetRow Dec 11, 2024
@Wondertan Wondertan mentioned this pull request Dec 12, 2024
Merged
Wondertan
Wondertan reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

share/shwap/getter.go Outdated Show resolved Hide resolved
share/shwap/p2p/bitswap/getter.go Show resolved Hide resolved
share/shwap/row.go Outdated Show resolved Hide resolved
store/getter.go Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed Dec 12, 2024
View reviewed changes
share/shwap/row_test.go Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed Dec 12, 2024
View reviewed changes
share/shwap/row.go Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed Jan 6, 2025
View reviewed changes
share/shwap/row.go Show resolved Hide resolved
xtoken.json Outdated Show resolved Hide resolved
share/shwap/row_test.go Outdated Show resolved Hide resolved
Wondertan
Wondertan requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized that this needs a Swamp test

@vgonkivs
Copy link
Member Author

vgonkivs commented Jan 9, 2025

Realized that this needs a Swamp test

We don't have swamp tests for Share module. I'd open a subsequent PR with swamp tests to not bloat this one.

cristaloleg
cristaloleg approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@vgonkivs vgonkivs merged commit c0055c5 into main Jan 9, 2025
29 of 30 checks passed
@vgonkivs vgonkivs deleted the implement_get_Row branch January 9, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@cristaloleg cristaloleg cristaloleg approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@vgonkivs vgonkivs

Labels
kind:feat Attached to feature PRs shwap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

modshare: GetRow method
3 participants
@vgonkivs @cristaloleg @Wondertan