perf(shwap): cache Both Row sides #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
walldiss and
cristaloleg
as code owners
Wondertan
force-pushed
the
shwap-cache-rows
branch
from
3956ee9 to
49e60d9
Compare
vgonkivs
approved these changes
Dec 12, 2024
|
There seems to be a consistent failure in one swamp test that I should look into before merging |
|
you mean this one #3990? |
walldiss
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
BothRowSideindicating that Row is "complete" and keeps both theLeftand theRidesides. TheSharesmethod now caches the decoded share and automatically convertsRowtoBothIt should be merged before #4002 so that JSON serialization contains the entire row and avoids expensive compute duplicatation.
Closes #3984