Skip to content

TA-4324: Add validation for git profile usage without git branch#268

Merged
Zgjim Haziri (ZgjimHaziri) merged 9 commits into
masterfrom
TA-4324-add-validation-for-git-profile-usage
Oct 8, 2025
Merged

TA-4324: Add validation for git profile usage without git branch#268
Zgjim Haziri (ZgjimHaziri) merged 9 commits into
masterfrom
TA-4324-add-validation-for-git-profile-usage

Conversation

@ZgjimHaziri

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Description

  • When sending gitProfile option, added validation which fails the command if the gitBranch is not provided alongside it.
  • Changed the way we handle options in the Command wrapper itself. The issue in more details:
    • Only the options of the command itself get passed to the action method. The global options don't get listed there even if sent.
    • GitProfile being a global option wasn't being recognized there at all.
    • Note: this hasn't caused problems with existing code. The issue showed itself only when a global para was needed in this case.

Relevant links

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) requested a review from a team as a code owner October 6, 2025 12:53
Buqeta
Buqeta (Buqeta) previously approved these changes Oct 6, 2025
@Buqeta

Copy link
Copy Markdown
Contributor

Just remembered: can you please add some test for these changes?

@ZgjimHaziri

Copy link
Copy Markdown
Contributor Author

Just remembered: can you please add some test for these changes?

We didn't have a setup for module.ts tests. Added one.

Buqeta
Buqeta (Buqeta) previously approved these changes Oct 7, 2025
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) merged commit b2fddea into master Oct 8, 2025
1 check passed
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) deleted the TA-4324-add-validation-for-git-profile-usage branch October 8, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants