Skip to content

TA-4324: Add validation for git profile usage without git branch #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zgjim Haziri (ZgjimHaziri) merged 9 commits into from
Oct 8, 2025
Merged

TA-4324: Add validation for git profile usage without git branch #268

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f1f477e
TA-4324: Add validation for git profile usage without git branch
ZgjimHaziri Oct 6, 2025
0cbd196
TA-4324: Add unit tests for module file
ZgjimHaziri Oct 6, 2025
4db80ab
TA-4324: Refactor tests
ZgjimHaziri Oct 6, 2025
092ac8c
TA-4324: Use the already provided testContext instead of mocking again
ZgjimHaziri Oct 6, 2025
926760b
TA-4324: Use gitProfile from context instead of from options
ZgjimHaziri Oct 6, 2025
7a036fc
TA-4324: Adapt tests
ZgjimHaziri Oct 6, 2025
71ffc0d
TA-4324: Refactor tests
ZgjimHaziri Oct 6, 2025
615a098
TA-4286: Use global option handler in the commands
ZgjimHaziri Oct 7, 2025
306ba73
TA-4286: Change back to asserting gitProfile option instead of the co…
ZgjimHaziri Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/commands/configuration-management/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ class Module extends IModule {
if ((options.packageKeys && options.keysByVersion) || (!options.packageKeys && !options.keysByVersion)) {
throw new Error("Please provide either --packageKeys or --keysByVersion, but not both.");
}
if (options.gitProfile && !options.gitBranch) {
throw new Error("Please specify a branch using --gitBranch when using a Git profile.");
}
options.withDependencies = options.withDependencies ?? false;
await new ConfigCommandService(context).batchExportPackages(options.packageKeys, options.keysByVersion, options.withDependencies, options.gitBranch, options.unzip);
}
Expand All @@ -94,6 +97,9 @@ class Module extends IModule {
}

private async batchImportPackages(context: Context, command: Command, options: OptionValues): Promise<void> {
if (options.gitProfile && !options.gitBranch) {
throw new Error("Please specify a branch using --gitBranch when using a Git profile.");
}
await new ConfigCommandService(context).batchImportPackages(options.file, options.directory, options.overwrite, options.gitBranch);
}

Expand Down