Some Bugfixes #2357
Merged
Some Bugfixes #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagner-intevation
force-pushed
the
bugfixes
branch
from
c8a073f
to
47c7b20
Compare
|
Added:
|
|
Added: |
avoids errors when parameters of Bot change now all derived classes are always compatible
if the streams stdout or stderr are already closed (e.g. during shutdown), ignore an error at flushing these streams
wagner-intevation
force-pushed
the
bugfixes
branch
from
096e5e4
to
36e505b
Compare
the job name 'build' does not fit here and is not unique ubuntu 20.04 is old, try 22.04
In Python 3.7, the logging of the previous bot run can end up in the logging of the next run, resulting in line 0 being: "Processed 1 messages since last logging." (written at shutdown of that bot)
prevents undefined variable errors in stop() if the logger is not yet initialized
these are accesses in stop(), so if the initialization fails before e.g. __message_counter["since"] was set, stop() will fail to to prevent this, create the variable beforehand same for the other variables
strip nullbytes from first line of bot log truncate log_stream before initializing bot instance ignore rare errors when the logs of the previous bot run appears in the logs of the current bot run
wagner-intevation
force-pushed
the
bugfixes
branch
from
44ecc22
to
6651e0a
Compare
|
I removed two commits which are not suitable for a bugfix release: @kamil-certat could you please have a look? |
kamil-certat
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids errors when parameters of Bot change
now all derived classes are always compatible