Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Bugfixes #2357

Merged
merged 16 commits into from
May 16, 2023
Merged

Some Bugfixes #2357

merged 16 commits into from
May 16, 2023

Commits on May 10, 2023

  1. Configuration menu
    Copy the full SHA
    4cd6a3a View commit details
    Browse the repository at this point in the history
  2. lib/bot: use *args, **kwargs for derived classes' constructors

    avoids errors when parameters of Bot change
    now all derived classes are always compatible
    wagner-intevation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0b5021f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2615dbf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e6e9abc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5384002 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e040141 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a1652e8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    af6995e View commit details
    Browse the repository at this point in the history
  9. lib/utils: StreamHandler: ignore closed stream on flushing

    if the streams stdout or stderr are already closed (e.g. during
    shutdown), ignore an error at flushing these streams
    wagner-intevation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    e54c8dc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d15026e View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    5eeac94 View commit details
    Browse the repository at this point in the history
  2. ci: ansible: use more current ubuntu version, suitable job name

    the job name 'build' does not fit here and is not unique
    ubuntu 20.04 is old, try 22.04
    wagner-intevation committed May 16, 2023
    Configuration menu
    Copy the full SHA
    940e6ac View commit details
    Browse the repository at this point in the history
  3. tst: be permission on python 3.7 with logging of previous bot runs

    In Python 3.7, the logging of the previous bot run can end up in the logging of the next run, resulting in line 0 being:
    "Processed 1 messages since last logging." (written at shutdown of that bot)
    wagner-intevation committed May 16, 2023
    Configuration menu
    Copy the full SHA
    dd6ab12 View commit details
    Browse the repository at this point in the history
  4. lib/bot: initialize logger variable with None

    prevents undefined variable errors in stop() if the logger is not yet
    initialized
    wagner-intevation committed May 16, 2023
    Configuration menu
    Copy the full SHA
    e9e0501 View commit details
    Browse the repository at this point in the history
  5. bot: create some variables on class level

    these are accesses in stop(), so if the initialization fails before e.g.
    __message_counter["since"] was set, stop() will fail to
    to prevent this, create the variable beforehand
    same for the other variables
    wagner-intevation committed May 16, 2023
    Configuration menu
    Copy the full SHA
    4798200 View commit details
    Browse the repository at this point in the history
  6. tst: logs of previous bot runs survived until the next bot run

    strip nullbytes from first line of bot log
    truncate log_stream before initializing bot instance
    ignore rare errors when the logs of the previous bot run appears in the logs of the current bot run
    wagner-intevation committed May 16, 2023
    Configuration menu
    Copy the full SHA
    6651e0a View commit details
    Browse the repository at this point in the history