Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneformerTokenizer updates #1199

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

GeneformerTokenizer updates #1199

wants to merge 3 commits into from

Conversation

mlin
Copy link
Contributor

@mlin mlin commented Jun 21, 2024

Updating our GeneformerTokenizer with features newly added upstream.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 43.47826% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (fc0281b) to head (9b2bcd3).

Current head 9b2bcd3 differs from pull request most recent head 4b996f8

Please upload reports for the commit 4b996f8 to get more accurate results.

Files Patch % Lines
...xperimental/ml/huggingface/geneformer_tokenizer.py 43.47% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
- Coverage   91.11%   90.93%   -0.19%     
==========================================
  Files          77       77              
  Lines        5922     5944      +22     
==========================================
+ Hits         5396     5405       +9     
- Misses        526      539      +13     
Flag Coverage Δ
unittests 90.93% <43.47%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant