Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LTS compat check bug #1244

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fix LTS compat check bug #1244

merged 2 commits into from
Jul 15, 2024

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Jul 12, 2024

No description provided.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (5cbad99) to head (f828f94).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1244      +/-   ##
==========================================
- Coverage   91.26%   91.26%   -0.01%     
==========================================
  Files          80       80              
  Lines        6330     6329       -1     
==========================================
- Hits         5777     5776       -1     
  Misses        553      553              
Flag Coverage Δ
unittests 91.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work, but my bash isn't that great.

@ivirshup ivirshup self-requested a review July 15, 2024 18:21
Copy link
Collaborator

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebezzi, I tried running the check again on this branch, but it looks like the same error is occurring:

Any idea what's up there? It looks like it's pointing at the right version of the workflow file.

@ivirshup
Copy link
Collaborator

ivirshup commented Jul 15, 2024

Looks like that is working now:

  if [ head-of-main == "head-of-main" ]; then
    pip install -e ./api/python/cellxgene_census/
  else
    pip install -U cellxgene_censushead-of-main
  fi

And the regular CI failure for this branch is due to the ongoing CI problems.

@ivirshup ivirshup merged commit 7612fb3 into main Jul 15, 2024
42 checks passed
@ivirshup ivirshup deleted the ebezzi/fix-lts-compat-workflow-2 branch July 15, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants