fix: capture visible viewport in VHS.Buffer
#658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runesoerensen
requested review from
meowgorithm and
andreynering
and removed request for
a team
The `VHS.Buffer` method was incorrectly reading from the top of the scrollback buffer. It now accounts for the scroll position (`viewportY`) to accurately capture the visible terminal viewport
runesoerensen
force-pushed
the
fix-testing-buffer
branch
from
f9bb6d0 to
e9c59ec
Compare
runesoerensen
changed the title
VHS.Buffer to capture visible viewport
runesoerensen
changed the title
VHS.Buffer to capture visible viewportVHS.Buffer
The new name more accurately describes that the method returns only the lines currently visible in the terminal's viewport, improving clarity and consistency with the related `CurrentLine` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
VHS.Buffermethod was incorrectly reading from the top of the scrollback buffer.This causes issues when using the
Wait+Screen /regex/command, and when writing output to golden files.The logic now accounts for the scroll position (
viewportY) to capture visible lines in the terminal viewport as expected.More details in the issues linked below (which both include the output after this change in the "Expected Behavior" sections, as well as steps to reproduce the current unexpected behavior).
Additional Style Changes
fill().map()withArray.from()for clarity.CurrentLinesand updated comments for clarity and accuracy.Related issue/discussion
Closes #657, closes #659
Checklist before requesting a review
CONTRIBUTING.md