xtask and build: consolidate platform parsing #614
Conversation
| let mut xxd_cmd = Command::new("xxd"); | ||
|
|
||
| let xxd_result = xxd_cmd | ||
| .arg("-p") | ||
| .arg("-c") | ||
| .arg("8") | ||
| .arg(&rom_binary) | ||
| .arg(&hex_binary) | ||
| .output(); | ||
|
|
||
| println!("Building {:?}", &hex_binary); | ||
|
|
||
| if xxd_result.is_err() || !xxd_result.as_ref().unwrap().status.success() { | ||
| bail!("xxd failed to build ROM hex"); | ||
| } |
There was a problem hiding this comment.
This seems like it could work well as a native Rust routine, otherwise we should document that xxd is a dependency for the builder tool.
Also, it would be good to include a comment that describes the shape of the hex data. Currently you would need to read the xxd manual to understand this snippet.
There was a problem hiding this comment.
OK, I will check. meanwhile I was told by the HW folks that I need to split it to two hex files, for two consecutive ROMs. I'm not sure if it's something specific to us or for everyone so I will remove it completely. hex is probably for all chip vendors. a split hex is probably specific to the FAB.
It would be nice for debugging to have an output ASM file too. If it's OK for all users I can add it too to this commit.
2 participants
xtask and builder:
Signed-off-by: Tali Perry [email protected]