Skip to content

Conversation

@cfrantz
Copy link

@cfrantz cfrantz commented Dec 10, 2025

Some environments do not permit docker or require exceptions to organization policies to use docker. Allow use of docker-compatible alternatives such as podman via the DOCKER environment variable.

Some environments do not permit docker or require exceptions to
organization policies to use docker.  Allow use of docker-compatible
alternatives such as `podman` via the `DOCKER` environment variable.

Signed-off-by: Chris Frantz <[email protected]>
@clundin25
Copy link
Collaborator

@cfrantz do you expect more tools to need this pattern?

Alternatively I would say the code should prefer podman and fallback to docker

@timothytrippel timothytrippel requested review from clundin25, timothytrippel and zhalvorsen and removed request for clundin25 December 11, 2025 01:38
@cfrantz
Copy link
Author

cfrantz commented Dec 12, 2025

@cfrantz do you expect more tools to need this pattern?

Alternatively I would say the code should prefer podman and fallback to docker

I don't know enough about this codebase yet to know. Of the tools listed in fpga/utils.rs, it seems like docker is the only one that has a compatible alternative like podman. My motivation for submitting this change is to solve the problem I'm experiencing in my environment.

I'm happy to generalize this solution (indeed, I tried to write something that would be generalizable), but I'd need some input from folks with more familiarity with the codebase than I to know where to land this solution.

@clundin25
Copy link
Collaborator

@cfrantz I think we can just make podman the default and fallback to docker. This approach is more flexible but I think we can be more opinionated in the tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants