Repository navigation
Introduce LockUntilReleaseRRArbiter - #5525
Open
dennisgnad wants to merge 1 commit into
Open
dennisgnad wants to merge 1 commit into
dennisgnad wants to merge 1 commit into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
LockUntilReleaseRRArbiterwhich is a locking round-robin arbiter that keeps the lock until areleasesignal allows another producer again.Use cases are for instance networks or streams in which a packet is transported over multiple clock cycles that have a
startandenddelimiter, and interleaving of the data with others is not allowed. In such a case, theendcan be connected to thereleasesignal of theLockUntilReleaseRRArbiter.Release Notes
This arbiter handles a gap in implementation of the current
LockingArbiterLike-arbiters, which only work on a fixed clock cycle count. The newly introduced arbiter is instead controlled by an external signal instead of just a fixed count.Development notes
I am a colleague of @maartenboersma and he suggested we could upstream this module, too. The question is, do we still need to provide tests of some sort? Other Chisel arbiters do not have them. Let me know what you still need for this PR, thanks!