Add a workflow to try to create a container using ghcr#437
Closed
mabruzzo wants to merge 2 commits intocholla-hydro:devfrom
Closed
Add a workflow to try to create a container using ghcr#437mabruzzo wants to merge 2 commits intocholla-hydro:devfrom
mabruzzo wants to merge 2 commits intocholla-hydro:devfrom
Conversation
I've done a lot of reading in the past week (before I ultimately just started trying things out). Initially, I tried to start with the regular ROCm image and then manually use sudo apt-get in the workflow to actually install the stuff we need... I've concluded that won't work... We need to install all build dependencies inside the container. So then I moved onto actually building the container with the github action. Ideally we want to be able to make some tweaks to the Dockerfile and let GitHub make all of the updates for us. I spent a bunch of time tinkering around within cholla-hydro#386, before I moved onto experimenting elsewhere... I have verified that this GHA **does** work. If it fails in this PR, it's because of a permissions issue
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done a lot of reading in the past week (before I ultimately just started trying things out).
Initially, I tried to start with the regular ROCm image and then manually use sudo apt-get in the workflow to actually install the stuff we need... I've concluded that won't work... We need to install all build dependencies inside the container.
So then I moved onto actually building the container with the github action. Ideally we want to be able to make some tweaks to the Dockerfile and let GitHub make all of the updates for us. I spent a bunch of time tinkering around within #386, before I moved onto experimenting elsewhere...
I have verified that this GHA does work. If it fails in this PR, it's because of a permissions issue