Conversation
I've done a lot of reading in the past week (before I ultimately just started trying things out). Initially, I tried to start with the regular ROCm image and then manually use sudo apt-get in the workflow to actually install the stuff we need... I've concluded that won't work... We need to install all build dependencies inside the container. So then I moved onto actually building the container with the github action. Ideally we want to be able to make some tweaks to the Dockerfile and let GitHub make all of the updates for us. I spent a bunch of time tinkering around within #386, before I moved onto experimenting elsewhere... I have verified that this GHA **does** work. If it fails in this PR, it's because of a permissions issue
mabruzzo
force-pushed
the
bump-container-image
branch
from
00900c5 to
ee7531d
Compare
mabruzzo
force-pushed
the
bump-container-image
branch
from
ee7531d to
5fc3258
Compare
|
@evaneschneider, this is ready for review. Please take a look at the .github/workflows/README.md file that I added and let me know if you find any part of it to be confusing (or if you think any part of it needs clarification). The goal was to provide detailed enough instructions to make it possible for anyone to bump the docker image (and provide basic context in case somebody eventually needs to make a more significant change) Aside: There is a small chance that I'll need to open a 2nd PR that adds the Footnotes
|
evaneschneider
left a comment
evaneschneider
left a comment
There was a problem hiding this comment.
All looks good to me!
2 participants
This is a reissue of #437 (I literally just moved the branch to the Cholla Repository). I think this was the source of all my problems!
I've done a lot of reading in the past week (before I ultimately just started trying things out).
Initially, I tried to start with the regular ROCm image and then manually use sudo apt-get in the workflow to actually install the stuff we need... I've concluded that won't work... We need to install all build dependencies inside the container.
So then I moved onto actually building the container with the github action. Ideally we want to be able to make some tweaks to the Dockerfile and let GitHub make all of the updates for us. I spent a bunch of time tinkering around within #386, before I moved onto experimenting elsewhere...