fix: add type-safe env var checks and improve FAILED transaction handling in webhook - #31
Open
consumeobeydie wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
app/api/circle/webhook/route.tshas two issues:TypeScript type error:
createClient()is called withprocess.env.NEXT_PUBLIC_SUPABASE_URLandprocess.env.SUPABASE_SERVICE_ROLE_KEYwhich are typed asstring | undefined. This causes a TypeScript compile error sincecreateClientexpectsstring.Silent failure on FAILED transactions: When a transaction fails on-chain, the handler only logs to console and skips any DB update. If the webhook fires and the transaction was never recorded as failed, there is no audit trail.
Silent failure after max retries: If a transaction cannot be matched after 10 attempts, the webhook silently returns 200 with no indication of the failure.
Fix
supabaseUrlandsupabaseServiceRoleKeyinto typed variables so TypeScript is satisfiedupdated_attimestamp update for FAILED transactions for audit trailconsole.errorlog when transaction cannot be matched afterMAX_ATTEMPTSChanges
app/api/circle/webhook/route.ts— type-safe env vars, FAILED transaction audit update, unmatched transaction log