Skip to content

fix: add type-safe env var checks and improve FAILED transaction handling in webhook #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
consumeobeydie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add type-safe env var checks and improve FAILED transaction handling in webhook #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions app/api/circle/webhook/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,18 @@ import crypto from "crypto";
import { NextRequest, NextResponse } from "next/server";
import { createClient } from "@supabase/supabase-js";

const supabaseUrl = process.env.NEXT_PUBLIC_SUPABASE_URL;
const supabaseServiceRoleKey = process.env.SUPABASE_SERVICE_ROLE_KEY;

if (!supabaseUrl || !supabaseServiceRoleKey) {
throw new Error(
"[arc-fintech] Missing required environment variables: NEXT_PUBLIC_SUPABASE_URL and SUPABASE_SERVICE_ROLE_KEY"
);
}

const supabaseAdmin = createClient(
process.env.NEXT_PUBLIC_SUPABASE_URL,
process.env.SUPABASE_SERVICE_ROLE_KEY,
supabaseUrl,
supabaseServiceRoleKey,
{
auth: {
autoRefreshToken: false,
Expand Down Expand Up @@ -97,8 +106,11 @@ export async function POST(req: NextRequest) {

if (notification.state === "FAILED") {
console.error(`Transaction ${notification.id} FAILED on chain. Reason: ${(notification as any).errorReason}`);
// Optional: Delete transaction or mark differently if possible.
// For now, we skip update to avoid DB error.
// Log failed transaction timestamp for audit purposes
await supabaseAdmin.from("transactions").update({
updated_at: new Date().toISOString(),
circle_transaction_id: notification.id,
}).eq("circle_transaction_id", notification.id);
} else if (newStatus) {
const txHash = (notification as any).txHash;

Expand Down Expand Up @@ -175,6 +187,13 @@ export async function POST(req: NextRequest) {
await wait(RETRY_DELAY_MS);
}
}
if (!updated) {
console.error(
`[arc-fintech] Webhook: Failed to match transaction after ${MAX_ATTEMPTS} attempts. ` +
`notification.id=${notification.id}, state=${notification.state}`
);
}


}
}
Expand Down