docs: correct README's description of the payment agent to match the actual implementation - #28
Open
pplmaverick wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discovered while studying the repo as a reference for building a live payment system on Arc.
The README describes the payment agent (
agent.mts, run vianpm run agent) as anLLM-driven agent built with LangChain and Deep Agents that "autonomously" decides which
tools to call, with a documented fallback to a "scripted mock run" and a natural-language
query example (
npm run agent -- "Buy me a quote at ...").None of this matches the actual implementation:
agent.mtshas zero references tolangchain,openai, ordeepagentsanywhere inthe file (verified via full read + repo-wide grep).
parseArgs()(agent.mts:15-32) only recognizes a single--limit <number>flag. Anyother CLI argument — including the quoted natural-language query shown in the README
example — is silently ignored and has no effect on execution.
OPENAI_API_KEYbranch, no LLM call, and no "mock mode" anywhere in thescript. The agent's behavior is unconditional and deterministic regardless of whether
OPENAI_API_KEYis set.BUYER_PRIVATE_KEY, deposit USDC into Circle Gateway (gateway.deposit), then run afixed
setIntervalloop (agent.mts:259-293) that round-robins through the 4 hardcoded/api/premium/*endpoints at 1 request/second, auto-topping-up the Gateway depositbelow a 0.5 USDC threshold (agent.mts:172, 199-221).
package.jsonstill lists@langchain/core,@langchain/openai, anddeepagentsasdependencies, but they are unused — not imported anywhere in the codebase.
This is misleading for anyone evaluating the demo's actual capabilities (e.g. assuming
it demonstrates LLM tool-use, or that the query example does something).
Changes
bullet to describe the agent as what it is: a scripted, deterministic payment loop.
npm run agent -- "Buy me a quote at ..."), since arbitrary arguments are silently ignored byparseArgs().OPENAI_API_KEYenabling"LLM-driven" behavior, since the script never reads that variable.
README.md. The unused LangChain/Deep Agentsdependencies in
package.jsonare a separate, follow-up cleanup (removing them, oractually wiring them up if LLM-driven behavior was the intent) and are out of scope
here.
Test plan
agent.mtsandpackage.jsonto confirm accuracy