avoid putting an ownerref on namespaces

cisco-open · Oct 27, 2020 · 6c21059 · 6c21059
1 parent 4253c2e
commit 6c21059
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pkg/reconciler/native.go b/pkg/reconciler/native.go
@@ -263,14 +263,16 @@ func (rec *NativeReconciler) Reconcile(owner runtime.Object) (*reconcile.Result,
 			}
 			rec.addRelatedToAnnotation(objectMeta, ownerMeta)
 			if rec.setControllerRef {
-				isCrd := false
+				skipControllerRef := false
 				switch o.(type) {
 				case *v1beta1.CustomResourceDefinition:
-					isCrd = true
+					skipControllerRef = true
 				case *v1.CustomResourceDefinition:
-					isCrd = true
+					skipControllerRef = true
+				case *corev1.Namespace:
+					skipControllerRef = true
 				}
-				if !isCrd {
+				if !skipControllerRef {
 					// namespaced resource can only own resources in the same namespace
 					if ownerMeta.GetNamespace() == "" || ownerMeta.GetNamespace() == objectMeta.GetNamespace() {
 						if err := controllerutil.SetControllerReference(ownerMeta, objectMeta, rec.scheme); err != nil {