Surveys: Fix I18n translation support and WYSIWYG support

[seamuslee001]

The "instructions" field is already a wysiyg in singlelingual mode.

Overview

This allows for the user interface to update the translation for the instructions field

Before

Database is translatable but UI does not support it

After

Both DB and UI support translating of the field

Technical Details

Note that on the form https://github.com/civicrm/civicrm-core/blob/master/CRM/Campaign/Form/Survey/Main.php#L126 https://github.com/civicrm/civicrm-core/blob/master/CRM/Campaign/Form/Petition.php#L174 it is already a WYSIWYG which means that RichTextEditor is the correct widget to use not TextArea

ping @demeritcowboy @eileenmcnaughton @mlutfy

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

So close!

It's strange because the english version seems ok. For some reason the other language shows the html.

[demeritcowboy]

Ah if I go back and edit the spanish now the english is html. So it's not being racist it's that there's some double escaping going on.

[seamuslee001]

hmm that does feel strange maybe something in the way the l10n form saves?

[seamuslee001]

@demeritcowboy I believe I have found the problem see civicrm/civicrm-packages#361

[mlutfy]

Correct me if i'm wrong, but I tweaked the PR title because it helps with release notes.

(I haven't tested yet, but sounds like a good catch)

[demeritcowboy]

The addition to skipfields seems to make it work without needing the packages PR. I don't see any other fields in core called "instructions", so there's no conflict. And it would likely be a wysiwyg if there were one added somewhere.

Out-of-scope:

• If you change the language while on the interview page everything changes except the instructions, but if you just go back and do the search again and then interview it works.
• The popup icon doesn't appear when first creating the record - you need to save and then go back and edit.

Also not a blocker for this PR: The ThankYou message on petition is translatable, but is html code in a regular textarea in the popup.

So am going to merge.