Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're serving the minified css but it's not in the build #60

Open
NickSto opened this issue Jan 25, 2024 · 0 comments · May be fixed by #61
Open

We're serving the minified css but it's not in the build #60

NickSto opened this issue Jan 25, 2024 · 0 comments · May be fixed by #61
Labels
bug Something isn't working

Comments

@NickSto
Copy link
Contributor

NickSto commented Jan 25, 2024

Currently (as of 075ba86), the CSS referenced by the html is css_new/uswds.min.css. Normally, that would be built from the source file css_new/uswds.css. But it's not actually being minified in the build process. The minified file we're actually serving is committed to the repo, so it's static unless anyone manually updates it.

Heads up: this bug was very hard to find because the mapping between the source file and minified file (css_new/uswds.min.css.map) is also a static file committed to the repo. So looking in the browser's dev tools shows unminified css that won't match the actual unminified css you're editing.

@NickSto NickSto added the bug Something isn't working label Jan 25, 2024
@NickSto NickSto linked a pull request Jan 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant