Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unminified css and remove minified #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NickSto
Copy link
Contributor

@NickSto NickSto commented Jan 25, 2024

Fixes #60

@sheldon-b
Copy link
Contributor

Almost! This looks good in desktop mode but I do notice that in mobile mode the responsiveness is broken. Let's fix that before merging this
Screenshot 2024-02-25 at 9 09 29 PM

@sheldon-b
Copy link
Contributor

sheldon-b commented Feb 26, 2024

note on how I tested it: the CI step for deploy/netlify links to a preview environment where this PR gets deployed to. Then I opened up the production website in another tab and compared them across all of the pages

@NickSto
Copy link
Contributor Author

NickSto commented Mar 7, 2024

I don't see the mobile issue anymore, nor the different font size I noticed previously 🤔

I've checked in the local version and the Netlify preview in Firefox and Chrome.

If someone else can verify, I think this is ready to merge.

@sheldon-b
Copy link
Contributor

@NickSto I still see the logo being broken in the netlify preview deployment. I did merge your other PR though

@NickSto
Copy link
Contributor Author

NickSto commented Mar 8, 2024

@sheldon-b Oh this PR doesn't cover the broken logo. I separated the issues, so this only changes us to be using the correct css file.

@sheldon-b
Copy link
Contributor

Got it. Do we need to migrate your fix from the logo-fixing PR into this PR before merging then, to make sure we don't break the logo again?

@NickSto
Copy link
Contributor Author

NickSto commented Mar 12, 2024

@sheldon-b That PR is entirely decoupled from this one. I moved the changes to main.css, and this only affects the uswds css files. So you should be able to merge this w/o affecting the logo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We're serving the minified css but it's not in the build
2 participants