PR_yiorgos - #20
Open
yiorgosc wants to merge 4 commits into
Open
Conversation
robdefeo
requested changes
Dec 12, 2024
Comment on lines
-95
to
+97
| "name": "ACME, Inc", | ||
| "vp": "eyJhbGciOiJFUzI1NiIsImtpZCI6ImRpZDp......kWRIKcFKwt4XR2nxI9GsqxRx9iCInkk0Pz6WPg" | ||
| "type": "AttorneyAppointment", | ||
| "donorJwt": "eyJhbGciOiJFUzI1NiIsImtpZCI6ImRpZDp......kWRIKcFKwt4XR2nxI9GsqxRx9iCInkk0Pz6WPg" |
Collaborator
There was a problem hiding this comment.
Unless there is a significant reason, I suggest following the existing standards that have been working on by the community, rather than creating new field definitions and usage. As far as I can see https://www.w3.org/TR/vc-data-model-2.0/#defn-EnvelopedVerifiableCredential covers the requirements.
Comment on lines
+96
to
+97
| "type": "AttorneyAppointment", | ||
| "donorJwt": "eyJhbGciOiJFUzI1NiIsImtpZCI6ImRpZDp......kWRIKcFKwt4XR2nxI9GsqxRx9iCInkk0Pz6WPg" |
Collaborator
There was a problem hiding this comment.
Suggested change
| "type": "AttorneyAppointment", | |
| "donorJwt": "eyJhbGciOiJFUzI1NiIsImtpZCI6ImRpZDp......kWRIKcFKwt4XR2nxI9GsqxRx9iCInkk0Pz6WPg" | |
| "type": "EnvelopedVerifiableCredential" |
| @@ -95,9 +93,8 @@ may begin. | |||
| "validUntil": "2024-12-26T15:24:05.394Z", | |||
| "evidence": [{ | |||
| "id": "urn:uuid:ad30da7b-a1cb-424f-b19a-efd458a1f865", | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| "id": "urn:uuid:ad30da7b-a1cb-424f-b19a-efd458a1f865", | |
| "id": "data:application/vc+jwt,eyJhbGciOiJFUzI1NiIsImtpZCI6ImRpZDp......kWRIKcFKwt4XR2nxI9GsqxRx9iCInkk0Pz6WPg", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.