Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more verbose versions of clockTicks #10

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

martijnbastiaan
Copy link
Member

Can be used to supply simulators such as Verilator with accurate timing information, which it in turn can use to produce accurate VCDs.

@martijnbastiaan
Copy link
Member Author

martijnbastiaan commented Jan 24, 2024

@cuddlefishie The current test strategy is to make sure that:

  1. The new functions draw the same conclusions w.r.t. clock ticks as clash-prelude's clockTicks.
  2. The new functions agree with each other.
  3. The new functions match manually calculated clock timestamps

This does fail to test that the timestamps the functions produce actually make sense. I did check by staring at the output really hard 👀, but if you want me to write a proper test I'll do so.

@martijnbastiaan
Copy link
Member Author

I did check by staring at the output really hard 👀, but if you want me to write a proper test I'll do so.

I've been shamed by @hiddemoll, I'll do it anyway.

@martijnbastiaan martijnbastiaan force-pushed the clockticks branch 3 times, most recently from f1f41d6 to 51da18e Compare January 24, 2024 15:37
Copy link
Contributor

@hydrolarus hydrolarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thank you! I just have one small documentation nitpick but other than that this seems very nice!

clash-vexriscv/src/VexRiscv/ClockTicks.hs Outdated Show resolved Hide resolved
clash-vexriscv/src/VexRiscv/ClockTicks.hs Show resolved Hide resolved
Can be used to supply simulators such as Verilator with accurate timing
information, which it in turn can use to produce accurate VCDs.
@martijnbastiaan martijnbastiaan merged commit 19897d8 into main Jan 25, 2024
5 checks passed
@martijnbastiaan martijnbastiaan deleted the clockticks branch January 25, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants