Cleanup #1399
Draft
Cleanup #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bike
force-pushed
the
cleanup
branch
2 times, most recently
from
42b4644
to
74e4508
Compare
Some of the stuff in the reader had to be changed since it used %s for characters, seemingly.
which means disabling a bunch of individual warnings, until I fix them up.
I don't actually totally understand how these are pessimizing; the basic case for this warning seems to be about copy elision in return values. My best guess is that it has something to do with the fact that takeError is defined to take ownership anyway, so I guess it is kind of a move operation already, and maybe returns a prvalue?
I'm not totally sure how ExecuteAction works, but I'm almost entirely sure it's not supposed to hang. I copied the Base:: use in the other ExecuteAction definition.
Some of these I'm not sure about, especially in the debugger. I don't think there's really a good way to write a bulletproof accessible_memory_p.
The order of C++ initializer lists is not used - fields are initialized in the order they are declared in the class. This matters when an initializer relies on another initialization in the same initializer list having been completed, but in general we probably ought to keep the orders the same to avoid any confusion.
The single dispatch miss stuff is not ready, and also I'm not entirely sure it needs its own lisp function.
This code makes fmt complain because we pass it a weird enum, but really the error message was unclear anyway.
On Macs, apparently, the underlying type of an enum is not int by default, so fmt complains if you use %d. The stream stuff I fixed up a bit since that's an ext: function and we should not be presenting users with internal codes.
|
Still a lot of warnings. Some macro redefinitions and a lot of reorder-ctor in cando. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly enables a lot more warnings in Clang.
Draft until I see any warnings on Mac and/or Cando are fixed.