Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #1399

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Cleanup #1399

wants to merge 22 commits into from

Commits on Feb 1, 2023

  1. Remove obsolete BF( code 

    Some of the stuff in the reader had to be changed since it used
%s for characters, seemingly.
    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    6a168c2 View commit details
    Browse the repository at this point in the history

  2. Enable -Wimplicit-fallthrough and clean up switch statements

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    21efcad View commit details
    Browse the repository at this point in the history

  3. Enable some warnings in CFLAGS

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ac1cb89 View commit details
    Browse the repository at this point in the history

  4. Enable -Wall 

    which means disabling a bunch of individual warnings, until I
fix them up.
    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    1feaf6b View commit details
    Browse the repository at this point in the history

  5. Remove pessimizing moves 

    I don't actually totally understand how these are pessimizing;
the basic case for this warning seems to be about copy elision in
return values. My best guess is that it has something to do with
the fact that takeError is defined to take ownership anyway, so
I guess it is kind of a move operation already, and maybe returns
a prvalue?
    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3ca4561 View commit details
    Browse the repository at this point in the history

  6. Fix infinite recursion 

    I'm not totally sure how ExecuteAction works, but I'm almost
entirely sure it's not supposed to hang. I copied the Base:: use in
the other ExecuteAction definition.
    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7daa946 View commit details
    Browse the repository at this point in the history

  7. Clean up some boolean expressions

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    e4b8a9e View commit details
    Browse the repository at this point in the history

  8. Delete obsolete probably-broken backtrace machinery

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    79d4a3e View commit details
    Browse the repository at this point in the history

  9. Fix uninitialized memory reads 

    Some of these I'm not sure about, especially in the debugger. I
don't think there's really a good way to write a bulletproof
accessible_memory_p.
    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ebe404f View commit details
    Browse the repository at this point in the history

  10. Clean up unused variables

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    f9dcfad View commit details
    Browse the repository at this point in the history

  11. Avoid redefining preprocessor macros

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    56a14ed View commit details
    Browse the repository at this point in the history

  12. Clean up reorder-ctor issues 

    The order of C++ initializer lists is not used - fields are
initialized in the order they are declared in the class. This
matters when an initializer relies on another initialization in the
same initializer list having been completed, but in general we
probably ought to keep the orders the same to avoid any confusion.
    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    1d6bd66 View commit details
    Browse the repository at this point in the history

  13. More warning cleanup 

    The single dispatch miss stuff is not ready, and also I'm not
entirely sure it needs its own lisp function.
    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    6e923c4 View commit details
    Browse the repository at this point in the history

  14. Clean up unused functions

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    6d76092 View commit details
    Browse the repository at this point in the history

  15. Clean up unused lambda captures

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    fd595f9 View commit details
    Browse the repository at this point in the history

  16. Clean up simple error 

    This code makes fmt complain because we pass it a weird enum, but
really the error message was unclear anyway.
    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    1e8d00d View commit details
    Browse the repository at this point in the history

  17. Print library versions

    @yitzchak @Bike
    yitzchak authored and Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a8980d8 View commit details
    Browse the repository at this point in the history

  18. Clean up some Mac deprecation warnings 

    On Macs, apparently, the underlying type of an enum is not int by
default, so fmt complains if you use %d.
The stream stuff I fixed up a bit since that's an ext: function
and we should not be presenting users with internal codes.
    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    b131ac2 View commit details
    Browse the repository at this point in the history

  19. Clean up some unused variables on Mac

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    c0e6229 View commit details
    Browse the repository at this point in the history

  20. Disable another clang warning

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    87c0a0e View commit details
    Browse the repository at this point in the history

  21. Fix some more Mac warnings

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    2250c5e View commit details
    Browse the repository at this point in the history

  22. More merging for cleanup branch

    @Bike
    Bike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    29f5174 View commit details
    Browse the repository at this point in the history