feat(backend,shared,clerk-js): Support suffixed cookies [CORE-2086] #3506
+698
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3e2faed The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
11 tasks
dimkl
force-pushed
the
CORE-2086/suffixed-cookies-draft
branch
2 times, most recently
from
f12aaa0
to
7dcea49
Compare
dimkl
requested review from
nikosdouvlis and
BRKalow
and removed request for
nikosdouvlis
dimkl
changed the title
dimkl
force-pushed
the
CORE-2086/suffixed-cookies-draft
branch
from
7dcea49
to
50ca6e3
Compare
dimkl
force-pushed
the
CORE-2086/suffixed-cookies-draft
branch
from
50ca6e3
to
6a7c065
Compare
dimkl
force-pushed
the
CORE-2086/suffixed-cookies-draft
branch
from
6a7c065
to
976ae21
Compare
colinclerk
reviewed
Jun 6, 2024
| return false; | ||
| } | ||
| const tokenIssuer = data.payload.iss.replace(/https?:\/\//gi, ''); | ||
| return this.frontendApi === tokenIssuer; |
There was a problem hiding this comment.
Did we check if this is correct for sites using proxy/domain/satellite?
There was a problem hiding this comment.
@colinclerk Yes. The issuer of our tokens is the same as our FapiURL. For the satellite apps, we are using the FapiURL of the primary domain, so this check is valid.
What are you referring to as domain?
dimkl
force-pushed
the
CORE-2086/suffixed-cookies-draft
branch
5 times, most recently
from
0655a51
to
da8dd2b
Compare
dimkl
force-pushed
the
CORE-2086/suffixed-cookies-draft
branch
4 times, most recently
from
e05b4b2
to
c6335a2
Compare
…cookies This change is required to support setting both suffixed/un-suffixed cookies using part of the publishableKey to support Multiple apps running on the same eTLD+1 domain or localhost. Setting both suffixed/un-suffixed cookies is used to support backwards compatibility.
The optionsAssertions module will include assertion function for options used across our package
…ence in AuthenticateContext
…g client_uat / session
…de@18 missing crypto.subtle
…secure context To avoid bundling the whole crypto-js library we used dynamic imports to load the dependency only if required and subpath imports to allow treeshake add only the required code parts from the crypto-js
dimkl
force-pushed
the
CORE-2086/suffixed-cookies-draft
branch
from
864369d
to
3e2faed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate suffixed and un-suffixed
__client_uat(in dev instance),__session,__clerk_db_jwt(In dev instance) cookies from ClerkJS and support reading the either the suffixed or the un-suffixed cookies in the backend SDK using the__client_uat&__sessioncookies.New ClerkJS versions will generate both suffixed and un-suffixed cookies but the backend SDK will consume only 1 of those 2.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change