Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend,shared,clerk-js): Support suffixed cookies [CORE-2086] #3506

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(backend,shared,clerk-js): Support suffixed cookies [CORE-2086] #3506

wants to merge 11 commits into from

Commits on Jul 4, 2024

  1. fix(clerk-js): Support get/set/remove into both suffixed/un-suffixed … 

    …cookies

This change is required to support setting both suffixed/un-suffixed
cookies using part of the publishableKey to support Multiple apps running
on the same eTLD+1 domain or localhost.
Setting both suffixed/un-suffixed cookies is used to support backwards compatibility.
    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    3913c09 View commit details
    Browse the repository at this point in the history

  2. chore(backend): Rename assertValidSecretKey file to optionsAssertions 

    The optionsAssertions module will include assertion function for options
used across our package
    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    90a69ab View commit details
    Browse the repository at this point in the history

  3. chore(backend): Enforce publishableKey/frontendApi/instanceType exist… 

    …ence in AuthenticateContext
    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    33859a2 View commit details
    Browse the repository at this point in the history

  4. chore(shared): Introduce cookie suffix utils to keys supath

    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    699858c View commit details
    Browse the repository at this point in the history

  5. chore(clerk-js): Use cookie suffix utils from the @clerk/shared/keys

    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    8323aae View commit details
    Browse the repository at this point in the history

  6. feat(backend): Determine usage of suffixed / un-suddixed cookies usin… 

    …g client_uat / session
    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    8002a79 View commit details
    Browse the repository at this point in the history

  7. fix(backend,shared,clerk-js): Improve cookie suffixes (#3543)

    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    4f5b1d2 View commit details
    Browse the repository at this point in the history

  8. fix(backend): Update tests pk & avoid using suffixed cookies in some … 

    …edge cases
    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    d5bedbb View commit details
    Browse the repository at this point in the history

  9. fix(shared,backend): Pass subtle as getCookieSuffix arg to support no… 

    …de@18 missing crypto.subtle
    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    7fb81dd View commit details
    Browse the repository at this point in the history

  10. fix(clerk-js): Use dev browser id instead of dev browser jwt in dev b… 

    …rowser creation
    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    3d5c5ed View commit details
    Browse the repository at this point in the history

  11. fix(clerk-js): Use crypto-js sha1 for cookie suffix generation on in-… 

    …secure context

To avoid bundling the whole crypto-js library we used dynamic imports to load the
dependency only if required and subpath imports to allow treeshake add only
the required code parts from the crypto-js
    @dimkl
    dimkl committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    98113a7 View commit details
    Browse the repository at this point in the history