Secrets endpoints #91
Conversation
| /// account id of owner of the script | ||
| pub account_identifier: &'a str, | ||
| /// the name of the script to attach the secret to | ||
| pub script_name: &'a str, |
There was a problem hiding this comment.
I'm starting to think that these should be owned strings
There was a problem hiding this comment.
What do you mean by these? @ashleymichal how should we apply this suggestion?
There was a problem hiding this comment.
Basically turn &'a str into a String
There was a problem hiding this comment.
we don't do this anywhere else :-\
There was a problem hiding this comment.
@sssilver i actually started turning all of these &'a str's into &'static str's elsewhere in wrangler. saves the requirement for lifetimes on all your structs and their methods. will illustrate in another pr.
| /// the variable name of the secret that will be bound to the script | ||
| pub name: String, | ||
| /// the string value of the secret | ||
| pub value: String, |
There was a problem hiding this comment.
Are secret values strings or bytes? It feels like the latter would be more proper, no?
There was a problem hiding this comment.
yah bytes is probably better
There was a problem hiding this comment.
except you can't precisely send a byte string in a json body...
There was a problem hiding this comment.
You can serialize them as a string, however within the Rust type system it should still be bytes
There was a problem hiding this comment.
That would force you to think about how that "string" should be deserialized. There isn't a single way to serialize bytes into a string.
There was a problem hiding this comment.
This was giving me a hard time. Since it's not a blocker I filed an issue to prioritize later #98
exvuma
force-pushed
the
victoria/secrets
branch
from
3a6f112 to
6f7da91
Compare
exvuma
force-pushed
the
victoria/secrets
branch
from
31b83af to
a3a0b00
Compare
exvuma
force-pushed
the
victoria/secrets
branch
from
a3a0b00 to
fc36a2d
Compare
| pub account_identifier: &'a str, | ||
| /// the name of the script to attach the secret to | ||
| pub script_name: &'a str, | ||
| /// secert's contents |
There was a problem hiding this comment.
s/secert/secret
Also all our comments elsewhere start with a capital, could you please change yours to be consistent? :)
Addition of the future Workers secret API endpoint