fix: handle read-only filesystem errors in icu_sync() #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was missed in previous commit
jcavejr
approved these changes
Sep 23, 2025
jcavejr
left a comment
jcavejr
left a comment
There was a problem hiding this comment.
LGTM 👍 I'm in need of the same patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
Treat
OSErrorwitherrno.EROFS(read-only filesystem) the same asPermissionError- continue to the next candidate folder instead of raising. This preserves the existing behavior whereicu_sync()tries multiple locations and gracefully handles write failures.Verified working on Project Bluefin which was failing in the same way as on #129 due to having a read-only
/usr/dir.