New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/cloudflare_tunnel #2866

Merged

jacobbednarz merged 6 commits into cloudflare:master from danquack:2720/tunnel

Oct 23, 2023

Contributor

danquack commented Oct 21, 2023 •

edited by jacobbednarz

Loading

closes #2720


          d/cloudflare_tunnel

e671938

danquack requested a review from jacobbednarz as a code owner

October 21, 2023 19:18

Contributor

github-actions bot commented Oct 21, 2023 •

edited

Loading

changelog detected ✅


          changelog

bf7d5a7

jacobbednarz reviewed

View reviewed changes

docs/data-sources/tunnel.md Outdated Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/data_source_tunnel.go Outdated Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/data_source_tunnel.go Outdated Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/data_source_tunnel.go Outdated Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/data_source_tunnel.go Outdated Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/data_source_tunnel.go Outdated Show resolved Hide resolved

jacobbednarz requested changes

View reviewed changes

Member

jacobbednarz left a comment

couple of small fixes mentioned inline but a solid start, thanks!

jacobbednarz mentioned this pull request

d/tunnel_virtual_network #2867

Merged

danquack added 2 commits

October 22, 2023 20:29


          Add example, update descriptions to use renderAvailableDocumentationV…

411fc24

…aluesStringSlice


          use make docs

f1e76f4

danquack requested a review from jacobbednarz

October 23, 2023 00:34

jacobbednarz added 2 commits

October 23, 2023 11:56


          make test reliable

3dcb9d6

use an explicit depends_on to make sure the resource always exists before attempting to find it


          remove extra period in description

e7ad83d

Member

jacobbednarz commented Oct 23, 2023

acceptance tests all looking good. thank you very much for the contribution!

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTunnel_MatchName" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTunnel_MatchName
--- PASS: TestAccCloudflareTunnel_MatchName (11.16s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	12.095s

jacobbednarz merged commit 0b3e4bd into cloudflare:master

9 checks passed

github-actions bot added this to the v4.18.0 milestone

github-actions bot pushed a commit that referenced this pull request


          Update CHANGELOG.md for #2866

6ad1058

danquack mentioned this pull request

feat: cloudflare_tunnel data source #2364

Closed

Contributor

github-actions bot commented Oct 31, 2023

This functionality has been released in v4.18.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet