Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to delete user_secret when disabling MFA if mfa_type is OTP #398

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

lhhyung
Copy link
Member

@lhhyung lhhyung commented Oct 21, 2024

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • Add logic to delete user_secret when disabling MFA if mfa_type is OTP

Known issue

@lhhyung lhhyung added the enhancement New feature or request label Oct 21, 2024
@lhhyung lhhyung self-assigned this Oct 21, 2024
Copy link

⚠️ @lhhyung the signed-off-by was not found in the following 1 commits:

  • a647715: feat: Add logic to delete user_secret when disabling MFA if mfa_type is OTP

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link

⚠️ @lhhyung the signed-off-by was not found in the following 2 commits:

  • a647715: feat: Add logic to delete user_secret when disabling MFA if mfa_type is OTP
  • 8cd86ed: feat: Add logic to delete user_secret when disabling MFA if mfa_type is OTP

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@lhhyung lhhyung merged commit 554b224 into cloudforet-io:master Oct 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fail/signedoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant