-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Ginkgo CLI #127
Conversation
2a7f07d
to
fdf91b7
Compare
In the CAPI pipeline, which was pointing at CATS
https://onsi.github.io/ginkgo/MIGRATING_TO_V2#timeout-behavior It would be great if this could PR could also introduce a |
fdf91b7
to
1cea028
Compare
Thanks for the feedback @sethboyles. I've updated the I also introduced the Ginkgo |
Rebased and force-pushed after merging #128 to fix merge conflicts. |
- Keep in sync with cf-acceptance-tests.
ae4e1d3
to
1c58f39
Compare
I've pulled the changes to the
PR #129 should address these warnings without needing to bump the version of the Ginkgo CLI included in the image. We should wait to merge this until we have cut a new release of CATs with the Ginkgo v2 changes. |
@davewalter - CATs 8.0.0 appears to satisfy your requirement note, unless I have misread this thread. Can this PR now be merged? |
@samcolson4 I think we're ready to merge this PR but have held off so far out of concern for the impact on folks who have not upgraded their projects to use ginkgo v2 and pull in this docker image with the We'd planned to send a message to the cf-dev mailing list first, to raise awareness of the change. However, other issues have come up in the last weeks that have diverted our attention. |
Just to note, when this PR gets merged, the lines I added in this PR can be reverted back to the old style of calling Ginkgo. |
Ginkgo v2 requires the CLI version to match the local version in the go.mod. Since we cannot predict the version used in individual go.mod files we should not install the CLI here, and should instead look to individual projects to vendor and use the tool appropriately. See [here](https://github.com/onsi/ginkgo/releases/tag/v2.3.1) for the release notes where Onsi outlines the versioning decision.
I've just sent out the cf-dev announcement. I figure we can wait a week or so to see if folks have thoughts / comments, and then look to move forward with this PR. |
What is this change about?
This PR bumps the version of the Ginkgo CLI included in the docker image to v2 to match the version used in CATs.Edit: This PR removes the ginkgo CLI from the docker image, as the version of the CLI must match the local Ginkgo library version in any given project. Therefore, we need to push the responsibility onto project owners to vendor and use the tool appropriately.
Please provide contextual information.
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How should this change be described in release notes?
This PR bumps the version of the Ginkgo CLI included in the docker image to v2 to match the version used in CATs.This PR removes the ginkgo CLI from the docker image.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@ctlong