chore: Follow up for the modal root fixes #4016
Merged
+49
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
force-pushed
the
fix-modal-root
branch
from
8db9171 to
57398e0
Compare
pan-kot
reviewed
Nov 6, 2025
| of the most recent getModalRoot call as an argument.", | ||
| "inlineType": { | ||
| "name": "(container: HTMLElement) => void", | ||
| "name": "(container: HTMLElement | null) => void", |
Member
Author
There was a problem hiding this comment.
It is. I already confirmed it is safe with a dry-run to live linked in the original component-toolkit CR: 7586509761
pan-kot
reviewed
Nov 6, 2025
| element.setAttribute('id', 'async-modal-root'); | ||
| document.body.appendChild(element); | ||
| if (!abortSignal.aborted) { | ||
| document.body.appendChild(element); |
Member
There was a problem hiding this comment.
Can we instead avoid calling this function when it is aborted?
Member
Author
There was a problem hiding this comment.
How do you imagine that? This function is async it is called on the start, and there is no way to abort it after it has been already called
pan-kot
approved these changes
Nov 6, 2025
| element.setAttribute('id', 'async-modal-root'); | ||
| document.body.appendChild(element); | ||
| if (!abortSignal.aborted) { | ||
| document.body.appendChild(element); |
just-boris
force-pushed
the
fix-modal-root
branch
from
57398e0 to
4c60f2a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4016 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 859 859
Lines 25396 25396
Branches 9048 9049 +1
=======================================
Hits 24699 24699
+ Misses 691 650 -41
- Partials 6 47 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to be merged after another change is released: cloudscape-design/component-toolkit#172
Related links, issue #, if available: n/a
How has this been tested?
The PR build will pass after the toolkit change is released to NPM. I will restart the build, but the code itself is ready for the review
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.