Skip to content

Conversation

@just-boris
Copy link
Member

@just-boris just-boris commented Nov 4, 2025

Notes

Fix for this issue: AWSUI-61285.

Technically this API change is breaking. I made sure no consumers will be affected by this change. Dry-run id: 7586509761

Testing

  1. Manually tested the original issue using the patched code, it works now
  2. The PR build is expected to fail, because there is an API snapshot diff. I will follow up with an update (chore: Follow up for the modal root fixes components#4016, currently in drafts)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (650399a) to head (bf8e451).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   98.77%   98.78%           
=======================================
  Files          36       36           
  Lines         900      905    +5     
  Branches      241      242    +1     
=======================================
+ Hits          889      894    +5     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris marked this pull request as ready for review November 5, 2025 14:32
@just-boris just-boris requested a review from a team as a code owner November 5, 2025 14:32
@just-boris just-boris requested review from SpyZzey and removed request for a team November 5, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant