Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLT menu development for 14_1_X (4/N) [15_0_X] #46804

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

HLT menu development for 14_1_X (4/N) [15_0_X] #46804

wants to merge 5 commits into from
+1,228 −719

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 26, 2024 •
edited
Loading

PR description:

Development of HLT menus for CMSSW_14_1_X (branch CMSSW_15_0_X): this is the close-out PR for HLT development in the CMSSW_14_1_X cycle.

  • This is the PR for the master branch, which will then be backported down to 14_1_X (the latter is the release cycle currently used for Run-3 HLT-menu development).
  • These updates correspond to the changes accumulated in the 14_1_X release cycle after the "V1.0" HIon menu for the 2024 PbPb data-taking period was released.

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3382 [HIN] Addition of a L1_FirstCollisionInTrain passthrough trigger for ZDC physics analysis
  • CMSHLT-3386 [ECAL] Downgrading EnergyInDeadEB/EE_FE Warning by setting logWarningEtThreshold_EB/EE_FE parameters in the HLT configuration to -1
  • CMSHLT-3388 [HIN/TRK] New centrality BS trigger for PbPb menu
  • CMSHLT-3390 [HIN/DQM] Misnaming of the output folders for DQM analyzers in HLTDQMPixelReconstructionPPOnAA
  • CMSHLT-3392 [TSG/DQM] Missing collections for HLT dqm client in PbPb 2024 runs
  • CMSHLT-3393 [HIN] New HLT paths for low pT double EG UPC triggers
  • CMSHLT-3394 [HIN/AlCa] Change of L1 seed for AlCa_EcalPhiSymForHI_v in the HIon menu
  • CMSHLT-3395 [HIN] Request for modifying UPC HLT paths for ZDC triggers
  • CMSHLT-3400 [HIN] Sync HIon table with online post-HIRun2024B
  • CMSHLT-3401 [HIN] Sync PRef table with online post-Run2024J

In addition, the following changes are included:

  • 6007679 : update of L1T HIon menu in TSG GTs to L1Menu_CollisionsHeavyIons2024_v1_0_6_xml
  • 24289e7 : move from L1Menu_Collisions2024_v1_3_0_xml to L1Menu_Collisions2024_v1_3_0-d1_xml in autoCondHLT in order to have the same firmware uuid as in the real data-taking
  • b06577f : fix buggy customization function customiseHLTFor46647
  • db1d41b: update phase1_2024_realistic_hi autoCond key to have the latest 2024 L1T HIon menu: L1Menu_CollisionsHeavyIons2024_v1_0_6_xml (as per this cmsTalk)

PR validation:

TSG integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_14_1_X (2024 PbPb data-taking release).

@mmusich
HLT menu development for 14_1_X (branch for 15_0_X)
6d3dc45 
These updates correspond to the changes accumulated in the 14_1_X release cycle after the "V1.0" HIon menu for the 2024 PbPb data-taking period was released.
This update includes the integration of the following JIRA tickets:

- [CMSHLT-3382](https://its.cern.ch/jira/browse/CMSHLT-3382) [HIN] Addition of a L1_FirstCollisionInTrain passthrough trigger for ZDC physics analysis
- [CMSHLT-3386](https://its.cern.ch/jira/browse/CMSHLT-3386) [ECAL] Downgrading EnergyInDeadEB/EE_FE Warning by setting logWarningEtThreshold_EB/EE_FE parameters in the HLT configuration to -1
- [CMSHLT-3388](https://its.cern.ch/jira/browse/CMSHLT-3388) [HIN/TRK] New centrality BS trigger for PbPb menu
- [CMSHLT-3390](https://its.cern.ch/jira/browse/CMSHLT-3390) [HIN/DQM] Misnaming of the output folders for DQM analyzers in HLTDQMPixelReconstructionPPOnAA
- [CMSHLT-3392](https://its.cern.ch/jira/browse/CMSHLT-3392) [TSG/DQM] Missing collections for HLT dqm client in PbPb 2024 runs
- [CMSHLT-3393](https://its.cern.ch/jira/browse/CMSHLT-3393) [HIN] New HLT paths for low pT double EG UPC triggers
- [CMSHLT-3394](https://its.cern.ch/jira/browse/CMSHLT-3394) [HIN/AlCa] Change of L1 seed for AlCa_EcalPhiSymForHI_v in the HIon menu
- [CMSHLT-3395](https://its.cern.ch/jira/browse/CMSHLT-3395) [HIN] Request for modifying UPC HLT paths for ZDC triggers
- [CMSHLT-3400](https://its.cern.ch/jira/browse/CMSHLT-3400) [HIN] Sync HIon table with online post-HIRun2024B
- [CMSHLT-3401](https://its.cern.ch/jira/browse/CMSHLT-3401) [HIN] Sync PRef table with online post-Run2024J
@mmusich
update of L1T HIon menu in TSG GTs to L1Menu_CollisionsHeavyIons2024_…
6007679 
…v1_0_6_xml
@mmusich
move from L1Menu_Collisions2024_v1_3_0_xml to L1Menu_Collisions2024_v…
24289e7 
…1_3_0-d1_xml in autoCondHLT in order to have the same firmware uuid as in the real data-taking
@mmusich
fix buggy customization function customiseHLTFor46647
b06577f
@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

type hlt-integration

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Nov 26, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2024 •
edited
Loading

cms-bot internal usage

This was referenced Nov 26, 2024
Open
Open
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46804/42805

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

test parameters:

  • workflows = 161, 161.02, 161.03, 161.1, 161.2, 161.3, 161.4, 180.0, 180.1, 181, 181.1

@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 920KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c7fe2/43097/summary.html
COMMIT: b06577f
CMSSW: CMSSW_15_0_X_2024-11-26-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46804/43097/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 26-Nov-2024 19:49:58 CET-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_HIUPC_DoubleJet16_DeltaPhi2p0_NotZDC1nOR_MaxPixelCluster10000_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sNotZDC1nORDoubleJet16DeltaPhi2p0BptxAND'
Exception Message:

Algorithm L1_DoubleJet16_DeltaPhi2p0_notZDC_Bkp1_OR_BptxAND, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_DoubleJet16_DeltaPhi2p0_notZDC_Bkp1_OR_BptxAND is present in the L1 menu

----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 26-Nov-2024 19:49:38 CET-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_HIUPC_DoubleJet16_DeltaPhi2p0_NotZDC1nOR_MaxPixelCluster10000_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sNotZDC1nORDoubleJet16DeltaPhi2p0BptxAND'
Exception Message:

Algorithm L1_DoubleJet16_DeltaPhi2p0_notZDC_Bkp1_OR_BptxAND, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_DoubleJet16_DeltaPhi2p0_notZDC_Bkp1_OR_BptxAND is present in the L1 menu

----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 26-Nov-2024 19:49:30 CET-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_HIUPC_DoubleJet16_DeltaPhi2p0_NotZDC1nOR_MaxPixelCluster10000_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sNotZDC1nORDoubleJet16DeltaPhi2p0BptxAND'
Exception Message:

Algorithm L1_DoubleJet16_DeltaPhi2p0_notZDC_Bkp1_OR_BptxAND, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_DoubleJet16_DeltaPhi2p0_notZDC_Bkp1_OR_BptxAND is present in the L1 menu

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53058
  • DQMHistoTests: Total failures: 78
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52980
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@mmusich
update phase1_2024_realistic_hi autoCond key to have the latest 2024 …
db1d41b 
…L1T HIon menu: L1Menu_CollisionsHeavyIons2024_v1_0_6_xml
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46804/42806

@cmsbuild
Copy link
Contributor

Pull request #46804 was updated. @Martin-Grunewald, @atpathak, @cmsbuild, @consuegs, @mmusich, @perrotta can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

@cmsbuild, please test

@mmusich mmusich changed the title HLT menu development for 14_1_X (4/N) [15_0_X] HLT menu development for 14_1_X (4/N) [15_0_X] Nov 26, 2024
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 924KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c7fe2/43101/summary.html
COMMIT: db1d41b
CMSSW: CMSSW_15_0_X_2024-11-26-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46804/43101/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 60 differences found in the comparisons
  • DQMHistoTests: Total files compared: 56
  • DQMHistoTests: Total histograms compared: 4789314
  • DQMHistoTests: Total failures: 446
  • DQMHistoTests: Total nulls: 160
  • DQMHistoTests: Total successes: 4788688
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 44.528000000000006 KiB( 55 files compared)
  • DQMHistoSizes: changed ( 161.02,... ): 5.566 KiB HLT/Filters
  • Checked 254 log files, 218 edm output root files, 56 DQM output files
  • TriggerResults: found differences in 1 / 54 workflows

GPU Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending code-checks-approved hlt-integration hlt-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
2 participants
@mmusich @cmsbuild