-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updates to proposal 1 #102
Conversation
Signed-off-by: Ross Fairbanks <[email protected]>
@rossf7 as you are adding the atom release here may be we can change the purpose of this pr itself if its okay? |
Signed-off-by: Ross Fairbanks <[email protected]>
@dipankardas011 Yes sure. Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ross Fairbanks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Signed-off-by: Ross Fairbanks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the spec after pairing session with @dipankardas011 to simplify the design.
Changes are
- We no longer use a github var to store the latest release
- Instead we trigger the pipeline once a day for the latest version of Falco
Not needing to maintain state simplifies and allows us to use bash for the workflow 🎉
@nikimanoledaki @AntonioDiTuri PTAL 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ross Fairbanks <[email protected]>
Signed-off-by: Ross Fairbanks <[email protected]>
Signed-off-by: Ross Fairbanks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
CI is failing with:
Run bash project-trigger.sh
GH_TOKEN not set
Error: Process completed with exit code 20.
Should the trigger script be running on PRs?
Co-authored-by: Niki Manoledaki <[email protected]>
@nikimanoledaki @dipankardas011 Thank you! I'll create an implementation issue for the renaming.
No I think it should only run if there is a change to scripts dir. Proposed a fix in #109 |
What type of PR is this?
kind/documentation
What this PR does / why we need it:
Update proposal 1 to
Also adds missing link to atom feed.
Which issue(s) this PR fixes:
None
Special notes for your reviewer (optional):
cc @dipankardas011