sosreport: Query sos policy for default tmp dir#22190
Merged
Merged
Conversation
2 tasks
sos 4.6.2 changed the tmp dir policy [1] from a static /var/tmp to a dynamic per-distro policy, which happens to be /tmp on Debian/Ubuntu right now. This is wrong, and there is no official way to query it [2]. To cope, query the sos policy for the tmp-dir, and only fall back to static /var/tmp if that fails. [1] sosreport/sos#4062 [2] sosreport/sos#4074
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sos 4.6.2 changed the tmp dir policy [1] from a static /var/tmp to a dynamic per-distro policy, which happens to be /tmp on Debian/Ubuntu right now. This is wrong, and there is no official way to query it [2].
To cope, query the sos policy for the tmp-dir, and only fall back to static /var/tmp if that fails.
[1] sosreport/sos#4062
[2] sosreport/sos#4074
This fixes cockpit-project/bots#7973 , I triggered an extra run against that image.